Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust cache cfg #1568

Merged
merged 2 commits into from
Oct 2, 2023
Merged

adjust cache cfg #1568

merged 2 commits into from
Oct 2, 2023

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Oct 2, 2023

Why this change is needed

to avoid errors when storing object in the cache, we need to reduce the shard size.
With the previous setup it was 512K.

What changes were made as part of this PR

  • adjust cache cfg
    -Also adjust the "create rollup" logic

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit 4525fd5 into main Oct 2, 2023
@tudor-malene tudor-malene deleted the tudor/adjust_cache_params branch October 2, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants